chore(Script): downgrade script syntax #5578

ArgoZhang · 2025-03-08T04:57:19Z

Link issues

Summary By Copilot

This pull request includes various improvements and bug fixes across multiple JavaScript files in the BootstrapBlazor components. The changes focus on improving code readability, ensuring proper handling of nullish values, and enhancing functionality.

Improvements to code readability and functionality:

src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.js: Modified the hideCallback function to use an explicit null check instead of optional chaining for better readability.
src/BootstrapBlazor/Components/Table/Table.razor.js: Improved the keyboard navigation logic by adding explicit null checks for previousElementSibling and nextElementSibling to avoid potential issues with optional chaining.

Enhancements to nullish value handling:

src/BootstrapBlazor/Components/Typed/Typed.razor.js: Replaced the nullish coalescing assignment operator (??=) with the logical OR assignment operator (||=) for the options object.
src/BootstrapBlazor/wwwroot/modules/fullscreen.js: Updated the toggle function to initialize the options object with a logical OR assignment and removed optional chaining for better compatibility.
src/BootstrapBlazor/wwwroot/modules/utility.js: Changed the initialization of the BootstrapBlazor object to use the logical OR assignment operator (||=) instead of the nullish coalescing assignment operator (??=).

Regression?

Yes
No

Risk

High
Medium
Low

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

sourcery-ai · 2025-03-08T04:57:23Z

Reviewer's Guide by Sourcery

This pull request downgrades the syntax of the JavaScript code to improve compatibility with older browsers. It replaces the optional chaining operator (?.) and the nullish coalescing operator (??) with more traditional JavaScript constructs.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Downgraded optional chaining and nullish coalescing operators for broader compatibility with older JavaScript environments.	Replaced `tr.previousElementSibling?.children` with `tr.previousElementSibling && tr.previousElementSibling.children`. Replaced `tr.nextElementSibling?.children` with `tr.nextElementSibling && tr.nextElementSibling.children`. Replaced `options?.id` with `options.id` after ensuring `options` is not null. Replaced `invoke?.invokeMethodAsync` with a conditional check for `invoke` before calling the method. Replaced `window.BootstrapBlazor ??= {}` with `window.BootstrapBlazor

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5577	Remove the `??=` syntax sugar.	✅
#5577	Remove the `?.` syntax sugar.	✅

Possibly linked issues

chore(Script): downgrade script syntax #5577: The PR directly addresses the issue by removing the specified syntax.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

This change appears to be downgrading the syntax, which might be necessary for compatibility, but consider if a build process could handle the syntax transformation instead.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

src/BootstrapBlazor/Components/Table/Table.razor.js

src/BootstrapBlazor/wwwroot/modules/fullscreen.js

codecov · 2025-03-08T04:59:34Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ba03fac) to head (a4d6166).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5578   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       649           
  Lines        29623     29623           
  Branches      4170      4170           
=========================================
  Hits         29623     29623

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ArgoZhang · 2025-03-08T05:05:50Z

@sourcery-ai review

ArgoZhang added 3 commits March 8, 2025 12:45

refactor: update ??= to ||=

49aee1a

refactor: 移除 ??= 表达式

c546bfb

refactor: 移除 ?. 表达式

5c08e72

bb-auto bot assigned ArgoZhang Mar 8, 2025

bb-auto bot added the enhancement New feature or request label Mar 8, 2025

bb-auto bot added this to the v9.4.0 milestone Mar 8, 2025

sourcery-ai bot previously approved these changes Mar 8, 2025

View reviewed changes

src/BootstrapBlazor/Components/Table/Table.razor.js Show resolved Hide resolved

src/BootstrapBlazor/Components/Table/Table.razor.js Show resolved Hide resolved

src/BootstrapBlazor/wwwroot/modules/fullscreen.js Outdated Show resolved Hide resolved

refactor: 精简代码

e1c2bd8

ArgoZhang dismissed sourcery-ai[bot]’s stale review via e1c2bd8 March 8, 2025 05:02

refactor: 重构代码

a4d6166

ArgoZhang merged commit edfdbe1 into main Mar 8, 2025
5 checks passed

ArgoZhang deleted the refactor-js branch March 8, 2025 05:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(Script): downgrade script syntax #5578

chore(Script): downgrade script syntax #5578

Uh oh!

ArgoZhang commented Mar 8, 2025 •

edited

Loading

Uh oh!

sourcery-ai bot commented Mar 8, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 8, 2025 •

edited

Loading

Uh oh!

ArgoZhang commented Mar 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

chore(Script): downgrade script syntax #5578

chore(Script): downgrade script syntax #5578

Uh oh!

Conversation

ArgoZhang commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link issues

Summary By Copilot

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Uh oh!

sourcery-ai bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide by Sourcery

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ArgoZhang commented Mar 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ArgoZhang commented Mar 8, 2025 •

edited

Loading

sourcery-ai bot commented Mar 8, 2025 •

edited

Loading

codecov bot commented Mar 8, 2025 •

edited

Loading